Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update errcheck to latest version #959

Closed
zendern opened this issue Feb 4, 2020 · 3 comments · Fixed by #1319
Closed

Update errcheck to latest version #959

zendern opened this issue Feb 4, 2020 · 3 comments · Fixed by #1319
Assignees
Labels
blocked Need's direct action from maintainer dependencies Relates to an upstream dependency duplicate This issue or pull request already exists linter: update version Update version of linter

Comments

@zendern
Copy link

zendern commented Feb 4, 2020

This maybe the wrong place for it so close it if it is but https://github.com/golangci/errcheck does not have the ability to create an issue.

But I wanted to open it up and get feedback on thoughts regarding updating that forked repo to have the latest version of what the forked repo has https://github.com/kisielk/errcheck.

The thing that golangci version is currently missing is the embedded interface walker stuff found here.

https://github.com/kisielk/errcheck/blob/master/internal/errcheck/embedded_walker.go

I believe updating that would resolve issue #656 and hopefully #657

@ernado ernado added the dependencies Relates to an upstream dependency label Feb 4, 2020
@ernado ernado added the blocked Need's direct action from maintainer label Feb 28, 2020
@divoxx
Copy link

divoxx commented May 15, 2020

What needs to be done for this to be merged?

@zendern
Copy link
Author

zendern commented May 16, 2020

What needs to be done for this to be merged?

Nothing to merge yet.... basically need to merge the original repo with the fork and resolve all the merge conflicts. I attempted and never finished. But had difficulties in trying to resolve those merge conflicts.

@jirfag jirfag added the linter: update version Update version of linter label May 17, 2020
@danielcooperxyz
Copy link

@zendern Looks like golangci/errcheck#4 may have synced up what you mentioned?

@SVilgelm SVilgelm added the duplicate This issue or pull request already exists label Feb 25, 2021
@SVilgelm SVilgelm linked a pull request Feb 25, 2021 that will close this issue
@SVilgelm SVilgelm self-assigned this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Need's direct action from maintainer dependencies Relates to an upstream dependency duplicate This issue or pull request already exists linter: update version Update version of linter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants