Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow concurrent invocations of golangci-lint on separate codebases #879

Closed
robertlamarre opened this issue Dec 3, 2019 · 5 comments
Labels
bug Something isn't working stale No recent correspondence or work activity

Comments

@robertlamarre
Copy link

Hello,

Pull #812 addressed issue #108, preventing multiple invocations of golangci-lint in parallel. However, we would like to be able to concurrently run multiple instances of golangci-lint validating separate applications. Is there any reason that this couldn't be done by this tool, perhaps by parameterizing the lock file used by the source tree being linted?

Thanks!

@tpounds tpounds added the bug Something isn't working label Dec 10, 2019
@ernado
Copy link
Member

ernado commented Jan 2, 2020

Current workaround is to set GOLANGCI_LINT_CACHE (which is path to cache dir) for each application.

@4m3ndy
Copy link

4m3ndy commented Jan 8, 2020

Current workaround is to set GOLANGCI_LINT_CACHE (which is path to cache dir) for each application.

Unfortunately this workaround didn't work for us, as we're using a mono-repo for our golang microservices, changing $TMPDIR for each application did the trick

cd $APP_PATH && env -i PATH="$PATH" TMPDIR="$PWD/tmp" golangci-lint -v run ./...

maybe you can try to add --lock-file option to set it through the cli

@SteelPhase
Copy link

I'm running into this as well, and it would appear that GOLANGCI_LINT_CACHE does not bypass the lock file check to allow multiple instances

@jirfag
Copy link
Member

jirfag commented May 9, 2020

Hi,
we've implemented the --allow-parallel-runners option in #1070. Cache in one dir should work for multiple runners but I'm not 100% sure, we don't have specific test cases for that.

storjBuildBot pushed a commit to storj/ci that referenced this issue Jun 5, 2020
There are related upstream issue that make this challenging. The work
around is pass a flag to allow multiple runners:

golangci/golangci-lint#812
golangci/golangci-lint#879

Change-Id: Iccb215d9ff1e54665d846104b4e282f7246ff424
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No recent correspondence or work activity label Jun 2, 2021
@stale stale bot closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale No recent correspondence or work activity
Projects
None yet
Development

No branches or pull requests

6 participants