unparam does not skip autogenerated files #799
Labels
Projects
Comments
tpounds
added
false positive
|
@tamalsaha Thanks for the report! I don't think there is an easy way to have |
|
I could add these generated files to a --skip-files. Could golanglint add an option to ignore build tags? These files are generated by tools in the Kubernetes project. They add a tag like below: If I could pass a flag like --skip-tags=ignore_autogenerated that would be easier. |
|
@tpounds see the autogenerated filter There are such comments: // Code generated by openapi-gen. DO NOT EDIT.
// This file was autogenerated by openapi-gen. Do not edit it manually! |
|
|
@jirfag Thanks for the info! If that's the case then these files should be ignored right? |
|
@tpounds yep, they should be ignored |
|
Please see the logs. GitHub repo: https://github.com/kubedb/apimachinery |
tpounds
added
bug
|
thank you, we need to debug it |
|
I'm having the same issue. It looks like the bug is in https://github.com/golangci/golangci-lint/blob/master/pkg/result/processors/autogenerated_exclude.go Func getDoc, around line 133, the scanner.scan for loop exits when it encounters a line that isn't a 1) "//" style comment, 2) an empty line, or 3) a package declaration. This means that in my case and in @tamalsaha's case, the block comment at the beginning of the file causes it to stop scanning, so it never reaches the DO NOT EDIT comment. |
theckman
pushed a commit
to theckman/golangci-lint
that referenced
this issue
May 3, 2020
$ git cherry --abbrev -v 0af0999fabfb ee9bf5809ead + abd8436 all: enable Go modules on CI (golangci#753) + 3c9d0fb checkers: recognize //line and //nolint in commentFormatting (golangci#756) + 0b517d7 checkers: extend deprecatedComment patterns (golangci#757) + 09100f6 checkers: use astcast package instead of coerce.go (golangci#758) + 2e9e97f checker: simplify boolExprSimplify (golangci#759) + 575701e make: add go-consistent to CI checks list (golangci#761) + b55f431 checkers: fix unlambda handling of builtins (golangci#763) + 5a7dee3 checker: handle lambdas properly in boolExprSimplify (golangci#765) + 5ce3939 checkers: teach boolExprSimplify a few new tricks (golangci#766) + 04d160f checkers: add new patterns to boolExprSimplify (golangci#768) + 09582e2 make: collect coverprofile separately from goveralls (golangci#769) + d8d0ee4 checkers: recognize NOTE pattern in deprecatedComment (golangci#770) + 12f0f85 Update copyright notice to 2019 (golangci#771) + f54bdb6 checkers: add stringXbytes checker + 170d65c checkers: followup for golangci#773 (golangci#774) + 84e9e83 checkers: make stringXbytes more linear (golangci#775) + a800815 checkers: add Depreacted typo pattern (golangci#776) + 6751be9 checkers: add hexLiterals (golangci#772) + ac61906 checkers: add typeAssertChain checker (golangci#782) + d19dbf1 checkers: add codegenComment checker (golangci#783) + d82b576 checkers: proper pkg/obj check for flagName (golangci#786) + dfcf754 ci: enable integration tests (golangci#787) + 5dafc45 checkers: fix equalFold false positive (golangci#788) + ed5e8e7 checkers: refactor and fix hexLiteral checker (golangci#789) + e704e07 checkers: add argOrder checker (golangci#790) + 34c1dc8 checkers: add Split handling to argOrder checker (golangci#791) + cbe095d checkers: add math.Max and math.Min to dupArg (golangci#792) + c986ee5 checkers: add checkers info fields test (golangci#794) + 66e5832 cmd/makedocs: use lintpack, fix build (golangci#793) + 6bce9d0 cmd/makedocs: add enabled/disabled by default info (golangci#795) + 4adbf9a checkers: simplify flagName (golangci#799) + 07de34a checkers: add octalLiteral checker (golangci#798) + 765907a cmd/makedocs: add checker param docs (golangci#796) + ee9bf58 cmd/makedocs: fix headers formatting (golangci#803)
|
Fixed by #1161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thank you for creating the issue!
Please include the following information:
Version of golangci-lint:
golangci-lint --version(or git commit if you don't use binary distribution)github.com/golangci/golangci-lint/cmd/golangci-lint@13e3a1a37556421d5dbad97bba07d7ff9a218931Config file:
cat .golangci.ymlThere is no such file
Go environment:
go version && go envGo 1.12
Verbose output of running:
golangci-lint run -vhttps://github.com/kubedb/apimachinery/pull/453/checks#step:3:50
The text was updated successfully, but these errors were encountered: