Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config keys with dots in them are parsed incorrectly #692

Closed
codyleyhan opened this issue Sep 14, 2019 · 2 comments
Closed

Config keys with dots in them are parsed incorrectly #692

codyleyhan opened this issue Sep 14, 2019 · 2 comments
Labels
bug Something isn't working stale No recent correspondence or work activity
Projects

Comments

@codyleyhan
Copy link
Contributor

golangci-lint: v1.18.0

I made a merged PR that added the ability to have users provide error messages for depguard, I had made and tested a similar PR for depguard, but did not do the same checks in this repo. I made a trivial use case of log in the test at https://github.com/golangci/golangci-lint/blob/master/test/testdata/depguard.go#L7.

After upgrading to this version, I noticed that when there are "." in a key in the config, the config is parsing incorrectly. This provides a bad experience as something like github.com/foo/bar will fail to parse. This was recently corrected in an unreleased PR in viper spf13/viper#673 that I believe will fix this issue when it is released.

I plan to make a PR to fix this as soon as a new release of viper is cut so that this bug will be fixed.

@codyleyhan codyleyhan changed the title Keys with dots in them are parsed incorrectly Config keys with dots in them are parsed incorrectly Sep 14, 2019
@sagikazarmark
Copy link

Please note that the change in Viper introduced a regression, so it will either be reverted or fixed (if that's possible at all).

@jirfag jirfag added the bug Something isn't working label Sep 24, 2019
@jirfag jirfag added this to Low priority in Zero Bug Oct 15, 2019
@stale
Copy link

stale bot commented Mar 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No recent correspondence or work activity label Mar 22, 2020
@stale stale bot closed this as completed Apr 5, 2020
Zero Bug automation moved this from Low priority to Closed Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale No recent correspondence or work activity
Projects
No open projects
Zero Bug
  
Closed
Development

No branches or pull requests

3 participants