Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support go1.13 #670

Merged
merged 1 commit into from Sep 9, 2019
Merged

Support go1.13 #670

merged 1 commit into from Sep 9, 2019

Conversation

jirfag
Copy link
Member

@jirfag jirfag commented Sep 9, 2019

Setup Travis CI to run on go 1.12 and 1.13.
Update info about go versions in README.
Rebuild go.mod,go.sum on go1.13.

Thank you for the pull request!

Setup Travis CI to run on go 1.12 and 1.13.
Update info about go versions in README.
Rebuild go.mod,go.sum on go1.13.
@jirfag jirfag merged commit 6163a8a into master Sep 9, 2019
@jirfag jirfag deleted the bug/fix-ci-build-on-go-1.11 branch September 9, 2019 18:54
@freeformz
Copy link

FWIW: w/o the go.mod changes here I can't go get github.com/golangci/golangci-lint, so I hope a new release happens soon.

@freeformz
Copy link

Additional note - Even with golangci-lint @ 1.17.1

$ go get github.com/golangci/golangci-lint/cmd/golangci-lint
go: github.com/golangci/golangci-lint@v1.17.1 requires
        github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540: invalid pseudo-version: does not match version-control timestamp (2019-05-26T07:48:19Z)

@zikaeroh
Copy link

zikaeroh commented Sep 9, 2019

Yes, this PR predates 1.17.1. You'd need to get @master to pick this up, or wait for the next tagged release.

@freeformz
Copy link

@zikaeroh Well master....

go get github.com/golangci/golangci-lint/cmd/golangci-lint@master
go: finding github.com/golangci/golangci-lint/cmd master
go: finding github.com/golangci/golangci-lint/cmd/golangci-lint master
go: finding github.com/golangci master
go: finding github.com/golangci/golangci-lint master
go: finding github.com master
go: downloading github.com/golangci/golangci-lint v1.17.2-0.20190909185456-6163a8a79084
go: extracting github.com/golangci/golangci-lint v1.17.2-0.20190909185456-6163a8a79084
# github.com/golangci/golangci-lint/pkg/lint
../../go/pkg/mod/github.com/golangci/golangci-lint@v1.17.2-0.20190909185456-6163a8a79084/pkg/lint/load.go:278:3: unknown field 'Logf' in struct literal of type "golang.org/x/tools/go/packages".Config

@freeformz
Copy link

PS: That is because the replacements need to be pulled forward into our project.

@tariq1890
Copy link
Contributor

Looking forward to a new release from this :)

@jirfag
Copy link
Member Author

jirfag commented Sep 10, 2019

I can't get rid of replacements until my pull requests to upstreams are merged. But I've changed replaced x/tools to be compatible with the replacement.
Now GO111MODULE=on go get github.com/golangci/golangci-lint/cmd/golangci-lint@95d5b2c works. And today-tomorrow I will make a new release.

@ldez ldez added this to the v1.18 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants