Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: remove duplicated test asserts #3608

Merged
merged 1 commit into from
Feb 17, 2023
Merged

dev: remove duplicated test asserts #3608

merged 1 commit into from
Feb 17, 2023

Conversation

alexandear
Copy link
Contributor

This test removes duplicated assert.Equal(t, test.expected.env, runner.env) line in TestRunnerBuilder_Runner.

@alexandear alexandear added the area: tests Continuous integration, tests and other checks label Feb 17, 2023
@ldez ldez added the topic: cleanup Related to code, process, or doc cleanup label Feb 17, 2023
@ldez ldez merged commit e23ac00 into golangci:master Feb 17, 2023
@alexandear alexandear deleted the dupl-test-assert branch February 17, 2023 21:31
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@alexandear @SeigeC
dev: remove duplicated test asserts (golangci#3608)
97f108c
@ldez ldez added this to the v1.51 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area: tests Continuous integration, tests and other checks topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Milestone
v1.51
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandear @ldez