Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

govet: enable timeformat by default #3602

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

johejo
Copy link
Contributor

@johejo johejo commented Feb 17, 2023

Updates #3353

It seems my comment was wrong in #3353. It was enabled by default in go vet.

https://github.com/golang/go/blob/release-branch.go1.20/src/cmd/vet/main.go

@ldez ldez changed the title Enable timeformat by default gover: enable timeformat by default Feb 17, 2023
@ldez ldez added enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint labels Feb 17, 2023
@ldez ldez changed the title gover: enable timeformat by default govet: enable timeformat by default Feb 17, 2023
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit a0893e3 into golangci:master Feb 17, 2023
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
@ldez ldez added this to the v1.51 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants