Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: add new source archive #3585

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Conversation

developer-guy
Copy link
Contributor

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 11, 2023

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2023

CLA assistant check
All committers have signed the CLA.

@ldez
Copy link
Member

ldez commented Feb 11, 2023

Hello,

Can you explain how valuable this PR is to you or the other users?

FYI, it's useless to ping Denis: he has not been active on the project for several years.
I recommend never pinging project maintainers directly as this can be considered harassment.

@ldez ldez added the feedback required Requires additional feedback label Feb 11, 2023
@developer-guy
Copy link
Contributor Author

I'm trying to add golangci-lint into the Wolfi OS; while working on this, I've noticed that there was no checksum entry for the source code tarball in the checksums.txt file, so, this PR is going to add it.

@ldez
Copy link
Member

ldez commented Feb 11, 2023

This is not exactly what your PR is doing: currently we don't "build" a source code tarball, the tarball is provided by GitHub itself for a release it's not related to our release system.

Your PR is adding the source code as a new tarball during the release, the checksum is just a consequence of this addition.

So can you change the PR title and the PR description?

@developer-guy developer-guy changed the title add source archive checksum into the checksums.txt add new source archive and checksum of it to the checksums.txt Feb 13, 2023
@developer-guy
Copy link
Contributor Author

developer-guy commented Feb 13, 2023

Your PR is adding the source code as a new tarball during the release, the checksum is just a consequence of this addition.

yeah, it is going to add a new source archive as a tarball, I've updated it accordingly. Thank you.

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@ldez ldez changed the title add new source archive and checksum of it to the checksums.txt add new source archive Feb 13, 2023
@ldez ldez added enhancement New feature or improvement area: ci PR that update CI and removed feedback required Requires additional feedback labels Feb 13, 2023
@ldez ldez changed the title add new source archive dev: add new source archive Feb 13, 2023
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez enabled auto-merge February 17, 2023 14:18
@ldez ldez disabled auto-merge February 17, 2023 14:18
@ldez ldez enabled auto-merge (squash) February 17, 2023 14:19
@ldez ldez merged commit 69e5481 into golangci:master Feb 17, 2023
@developer-guy
Copy link
Contributor Author

Thank you so much for your assistance ☝️ really appreciate it 🫶

SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
@ldez ldez added this to the v1.51 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci PR that update CI enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants