Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change not to use linter with AGPL lisence #3337

Closed
momom-i opened this issue Nov 1, 2022 · 12 comments
Closed

Change not to use linter with AGPL lisence #3337

momom-i opened this issue Nov 1, 2022 · 12 comments
Assignees
Labels
enhancement New feature or improvement

Comments

@momom-i
Copy link

momom-i commented Nov 1, 2022

Your feature request related to a problem? Please describe.

Hi, I've used golangci-lint but after upgrading its version to latest one, I found the linter with AGPL lisence was added(github.com/leonklingele/grouper, PR: #2497).
I can't find discussion around it, but I don't think it's a good idea to use that because user might have to disclose their source codes.

Describe the solution you'd like.

Changing its license or not to use it

Describe alternatives you've considered.

If there is a special reason, we might not have to change it.

Additional context.

No response

@momom-i momom-i added the enhancement New feature or improvement label Nov 1, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 1, 2022

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@ldez
Copy link
Member

ldez commented Nov 1, 2022

Hello,

our license is GPL, you already have to disclose your code.

https://github.com/golangci/golangci-lint/blob/master/LICENSE

The GNU Affero General Public License is a modified version of the ordinary GNU GPL version 3. It has one added requirement: if you run a modified program on a server and let other users communicate with it there, your server must also allow them to download the source code corresponding to the modified version running there.

The AGPL variant is about usage over a network, in the case of golangci-lint it doesn't make a real difference.

Feel free to ask https://github.com/leonklingele/grouper for changing the license.

@ldez ldez added the feedback required Requires additional feedback label Nov 1, 2022
@bombsimon
Copy link
Member

According to #232, Google does not allow AGPL licenses. The issue references this page which explains why it's not allowed at Google.

@ldez
Copy link
Member

ldez commented Nov 1, 2022

I'm not happy to be forced by Google to follow their rules.
But we will follow the initial direction, I asked to @leonklingele to change the license of grouper leonklingele/grouper#1.

If the license is not changed we will just drop the linter.

@ldez ldez removed the feedback required Requires additional feedback label Nov 1, 2022
@ldez ldez self-assigned this Nov 1, 2022
@momom-i
Copy link
Author

momom-i commented Nov 2, 2022

Thank you for listening to my opinion. I'm waiting for that.

@momom-i
Copy link
Author

momom-i commented Nov 7, 2022

@ldez How is it going?

@ldez
Copy link
Member

ldez commented Nov 7, 2022

Just be clear: our license is GPL, you must already disclose any changes you make in the golangci-lint code, the grouper license doesn't change that.

As you can see, we are still waiting for an answer of @leonklingele

@leonklingele
Copy link
Member

I'm a bit busy these days but will get back to this asap.

@momom-i
Copy link
Author

momom-i commented Nov 10, 2022

@ldez In my understanding, the difference between GPL and AGPL is disclosure range. As you said, GPL has surely obligation to disclose codes if developer provides binary using a module with that license in public, but when they provides web service using that in server side, they don't have to disclose their codes.
And AGPL don't allow that case.
Anyway, personally, our company doesn't allow us to use AGPL module. So I'd appreciate if you'd decide whether change it or not soon because we need to consider whether to continue using golangci-lint in some cases.

@leonklingele
Copy link
Member

leonklingele commented Nov 16, 2022 via email

@ldez
Copy link
Member

ldez commented Nov 16, 2022

It’s because AGPL is not allowed at Google and other companies.

leonklingele added a commit to leonklingele/grouper that referenced this issue Nov 23, 2022
@leonklingele
Copy link
Member

#3372

@ldez ldez closed this as completed Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

4 participants