Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/spf13/cobra from 1.5.0 to 1.6.0 #3298

Merged
merged 2 commits into from Oct 15, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 15, 2022

Bumps github.com/spf13/cobra from 1.5.0 to 1.6.0.

Release notes

Sourced from github.com/spf13/cobra's releases.

v1.6.0

Summer 2022 Release

Some exciting changes make their way to Cobra! Command completions continue to get better and better (including adding --help and --version automatic flags to the completions list). Grouping is now possible in your help output as well! And you can now use the OnFinalize method to cleanup things when all "work" is done. Checkout the full changelog below:


Features 🌠

Deprecation 👎🏼

  • ExactValidArgs is deprecated (but not being removed entirely). This is abit nuanced, so checkout #1643 for further information and the updated user_guide.md on how this may affect you (and how you can take advantage of the correct behavior in the validators): @​umarcor #1643

Bug fixes 🐛

Dependencies 🗳️

Testing 🤔

Docs ✏️

Misc 💭

Note: Per #1804, we will be moving away from "seasonal" releases and doing more generic point release targets. Continue to track the milestones and issues in the spf13/cobra GitHub repository for more information!

Great work everyone! Cobra would never be possible without your contributions! 🐍

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.5.0...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Relates to an upstream dependency go Pull requests that update Go code labels Oct 15, 2022
@ldez
Copy link
Member

ldez commented Oct 15, 2022

The GitHub GraphQL seems to bug: only the 10 first releases are returned instead of the 100 first.

I checked:

There is nothing about that, so I think it's a bug.

I tried the GitHub GraphQL API Explorer

Query
query ($owner: String!, $name: String!, $releasesCursor:  String){
  repository(owner: $owner, name: $name) {
    releases(first: 100, after: $releasesCursor) {
      nodes {
        tagName
#        releaseAssets(first: 50) {
#          nodes {
#            downloadUrl
#          }
#        }
      }
      pageInfo {
        endCursor
        hasNextPage
      }
    }
  }
}
Variables
{
  "owner": "golangci",
  "name": "golangci-lint",
  "releasesCursor": null
}
Results
{
  "data": {
    "repository": {
      "releases": {
        "nodes": [
          {
            "tagName": "v1.50.0"
          },
          {
            "tagName": "v1.49.0"
          },
          {
            "tagName": "v1.48.0"
          },
          {
            "tagName": "v1.47.3"
          },
          {
            "tagName": "v1.47.2"
          },
          {
            "tagName": "v1.47.1"
          },
          {
            "tagName": "v1.47.0"
          },
          {
            "tagName": "v1.46.2"
          },
          {
            "tagName": "v1.46.1"
          },
          {
            "tagName": "v1.46.0"
          }
        ],
        "pageInfo": {
          "endCursor": "MTA",
          "hasNextPage": false
        }
      }
    }
  }
}

https://github.com/orgs/community/discussions/36234

@ldez
Copy link
Member

ldez commented Oct 15, 2022

I will merge this one to fix the other problem related to x/text

@ldez ldez enabled auto-merge (squash) October 15, 2022 11:59
@ldez ldez disabled auto-merge October 15, 2022 11:59
@ldez ldez merged commit a760cb1 into master Oct 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the dependabot/go_modules/github.com/spf13/cobra-1.6.0 branch October 15, 2022 11:59
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
…i#3298)

Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
@ldez ldez added this to the v1.50 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant