Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove redundant character escape '\/' #3278

Merged
merged 1 commit into from Oct 5, 2022
Merged

fix: remove redundant character escape '\/' #3278

merged 1 commit into from Oct 5, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Oct 5, 2022 •
edited

  • clean \/ when it's redundant
  • factorize the NormalizePathInRegex

fixes #3277

@ldez ldez added bug Something isn't working platform: windows Issue that is related to Windows labels Oct 5, 2022
bombsimon
bombsimon approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@ldez ldez merged commit d03294f into golangci:master Oct 5, 2022
@ldez ldez deleted the fix/win-redundant-escape branch October 5, 2022 22:09
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez @SeigeC
fix: remove redundant character escape '\/' (golangci#3278)
dfffeac
@ldez ldez added this to the v1.50 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working platform: windows Issue that is related to Windows
Projects
None yet
Milestone
v1.50
Development

Successfully merging this pull request may close these issues.

processors: incorrect path regex normalization leads to panic
2 participants
@ldez @bombsimon