Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update gofmt and goimports and add option "rewrite-rules" #3174

Merged
merged 2 commits into from Sep 1, 2022
Merged

feat: update gofmt and goimports and add option "rewrite-rules" #3174

merged 2 commits into from Sep 1, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 1, 2022 •
edited

Update gofmt and goimports.

Add the option rewrite-rules:

linters-settings:
  gofmt:
    rewrite-rules:
      - pattern: 'a[b:len(a)]'
        replacement: 'a[b:]'

golangci/gofmt@244bba7...f2edd75

Fixes #3171

@ldez ldez added enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint labels Sep 1, 2022
@ldez ldez mentioned this pull request Sep 1, 2022
Closed
@ldez ldez marked this pull request as draft September 1, 2022 08:56
@ldez ldez marked this pull request as ready for review September 1, 2022 12:11
bombsimon
bombsimon approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ldez ldez enabled auto-merge (squash) September 1, 2022 12:18
@ldez ldez merged commit aba80c7 into golangci:master Sep 1, 2022
@ldez ldez deleted the feat/update-gofmt branch September 1, 2022 12:25
@ldez ldez mentioned this pull request Sep 7, 2022
Closed
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez @SeigeC
feat: update gofmt and goimports and add option "rewrite-rules" (gola…
fcb621b 
…ngci#3174)
@ldez ldez added this to the v1.50 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Milestone
v1.50
Development

Successfully merging this pull request may close these issues.

gofmt: support rewrite rule
2 participants
@ldez @bombsimon