Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: fix: linter tests #3128

Merged
merged 1 commit into from Aug 23, 2022
Merged

dev: fix: linter tests #3128

merged 1 commit into from Aug 23, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Aug 22, 2022

I made a mistake here: https://github.com/golangci/golangci-lint/pull/3124/files#diff-2d27f13815d27a52a927014f02a8d7545106cf3db781eb5de69e1f89ec689376R52

I just forget to remove my dev constraint.

only one linter test was running instead of all linter tests.

@ldez ldez added bug Something isn't working area: tests Continuous integration, tests and other checks labels Aug 22, 2022
@ldez ldez requested a review from bombsimon August 22, 2022 22:16
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry for not spotting this! 🙈 LGTM

@ldez ldez merged commit 77962e9 into golangci:master Aug 23, 2022
@ldez ldez deleted the fix/linter-tests branch August 23, 2022 08:33
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez ldez added this to the v1.49 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests Continuous integration, tests and other checks bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants