build(deps): bump github.com/go-critic/go-critic from 0.6.3 to 0.6.4

[dependabot]

Bumps github.com/go-critic/go-critic from 0.6.3 to 0.6.4.

Release notes

Sourced from github.com/go-critic/go-critic's releases.

v0.6.4

• Updated ruleguard and x/tools
• all: use cristalhq/acmd #1198
• checkers: add time range expr simplify (go-critic/go-critic#1220)
• ci: add Go 1.18 (go-critic/go-critic#1240)
• checkers: turn init() for embedded rules into exported func (go-critic/go-critic#1246)
• checkers: don't call SizeOf for type parameters (go-critic/go-critic#1237)
• checkers: supported generics for typeDefFirst and paramTypeCombine (go-critic/go-critic#1239)
• checkers: use ctx.SizeOf instead of SizesInfo.SizeOf (go-critic/go-critic#1247)

A special thanks goes to @​mcdoker18, @​cristaloleg and @​peakle + everyone who helps to keep this project afloat.

Commits

• d9c2d89 update ruleguard to 0.3.17 (#1249)
• dfd27d0 checkers: use ctx.SizeOf instead of SizesInfo.SizeOf (#1247)
• f1528e1 checkers: supported generics for typeDefFirst and paramTypeCombine (#1239)
• af0e6d7 checkers: don't call SizeOf for type parameters (#1237)
• 8df9d7e checkers: turn init() for embedded rules into exported func (#1246)
• 1d7d822 ci: add Go 1.18 (#1240)
• 4f19cad deps: bump github.com/cristalhq/acmd from 0.5.7 to 0.7.0 (#1236)
• 7cb5c45 deps: bump toolmantim/release-drafter from 5.2.0 to 5.20.0 (#1231)
• ed6b4df deps: bump actions/setup-go from 1 to 3 (#1228)
• 7c630aa deps: bump actions/checkout from 1 to 3 (#1229)
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Related to #3107

[quasilyte]

The failure due to the embedded rules that were moved to checkers.InitEmbeddedRules().
If it's not called, embedded rules are not "registered".
My guess is that when we'll add a checkers.InitEmbeddedRules() call when gocritic is enabled, this issue will go away.

[ldez]

I will have to rewrite the configuration parsing.

[ccoVeille]

Thank you

[hakankoklu]

How long do you think it will take for a new version to be released that has this change?

[pierrre]

Is go-critic supposed to work with a package containing generic code, with golangci-lint v1.49.0 ?
I still get a panic with an "unreachable" message.
I can provide a proper debug log or open an issue if you want.

Yes my GOROOT variable is set.

[ldez]

@pierrre can you put your feedback in the issue (with the output stack) #3107

[ldez]

@pierrre maybe you can create a new issue because your problem seems not related to #3107