Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nosnakecase: deprecate linter #3065

Merged
merged 7 commits into from Aug 5, 2022
Merged

Conversation

sivchari
Copy link
Member

@sivchari sivchari commented Aug 5, 2022

I proposal to disable nosnakecase linter. This rule is almost duplicated with revive(var-naming). In addition, the linter detects std libs or auto generated file (e.g. mockgen, protocol buffer etc...). These results is right, but it's not helpful.
Sorry, it's my fault.

FYI
Option to disable for imported libraries
Difference/relation to Revive's var-naming check?

@ldez ldez self-requested a review August 5, 2022 09:32
@ldez ldez self-assigned this Aug 5, 2022
@ldez ldez changed the title Feat: disable nosnakecase nosnakecase: deprecate linter Aug 5, 2022
@ldez ldez added the linter: update Update the linter implementation inside golangci-lint label Aug 5, 2022
@ldez
Copy link
Member

ldez commented Aug 5, 2022

Hello,
You cannot remove a linter: the linter must be deprecated before

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit d4fd2db into golangci:master Aug 5, 2022
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
@ldez ldez added this to the v1.49 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants