Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panics with go1.19 #3053

Closed
4 tasks done
maxatome opened this issue Aug 3, 2022 · 2 comments
Closed
4 tasks done

Panics with go1.19 #3053

maxatome opened this issue Aug 3, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@maxatome
Copy link

maxatome commented Aug 3, 2022

Welcome

  • Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).
  • Yes, I've tried with the standalone linter if available. (https://golangci-lint.run/usage/linters/)

Description of the problem

With go1.18.3 installed, golangci-lint works well:

> go version; golangci-lint version
go version go1.18.3 linux/amd64
golangci-lint has version 1.47.2 built from 61673b34 on 2022-07-21T10:53:45Z

With go1.19 installed, the same golangci-lint panics after ~14 secs:

> go version; golangci-lint version
go version go1.19 linux/amd64
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
	github.com/go-critic/go-critic@v0.6.3/checkers/embedded_rules.go:47 +0x4b4

Version of golangci-lint

$ golangci-lint version
golangci-lint has version 1.47.2 built from 61673b34 on 2022-07-21T10:53:45Z

Configuration file

none

Go environment

$ go version && go env
go version go1.19 linux/amd64
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/xxx/.cache/go-build"
GOENV="/home/xxx/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/xxx/zz/go/pkg/mod"
GOOS="linux"
GOPATH="/home/xxx/Projet/go"
GOROOT="/home/xxx/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/xxx/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.19"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/xxx/wd/go-testdeep/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2144936495=/tmp/go-build -gno-record-gcc-switches"

Verbose output of running

$ golangci-lint cache clean
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
	github.com/go-critic/go-critic@v0.6.3/checkers/embedded_rules.go:47 +0x4b4
$ golangci-lint run -v

panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
	github.com/go-critic/go-critic@v0.6.3/checkers/embedded_rules.go:47 +0x4b4

Code example or link to a public repository

anywhere as golangci-lint version alone panics.

@maxatome maxatome added the bug Something isn't working label Aug 3, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 3, 2022

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@ldez
Copy link
Member

ldez commented Aug 3, 2022

Hello,

currently, golangci-lint doesn't support go1.19

please follow #3037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants