new-linter: ireturn (checks for function return type) #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
requested changes
Sep 5, 2021
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
|
All issues from the previous CR are fixed, I will be glad if you can take a second look to spot any issues that left? |
ldez
requested changes
Sep 6, 2021
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
ldez
force-pushed
the
newLinterIReturn
branch
from
fe20890
to
d8e0621
Compare
ldez
force-pushed
the
newLinterIReturn
branch
from
d8e0621
to
0f1cd16
Compare
ldez
approved these changes
Sep 7, 2021
|
Thank you for the corrections and approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new linter
ireturnthat checks for function's returned types and adds the possibility to reject or allow specific types of interfaces.https://github.com/butuzov/ireturn
TL/DR
Accept Interfaces, Return Concrete Types