Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revive: allow to disable a rule #2055

Merged
merged 1 commit into from Jun 15, 2021
Merged

revive: allow to disable a rule #2055

merged 1 commit into from Jun 15, 2021

Conversation

ofw
Copy link
Contributor

@ofw ofw commented Jun 15, 2021

No description provided.

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 15, 2021

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@ldez ldez added enhancement New feature or improvement feedback required Requires additional feedback labels Jun 15, 2021
@ldez
Copy link
Member

ldez commented Jun 15, 2021 •
edited

Hello @ofw, you have to add the email that you used to create your commit to your GitHub account configuration and sign the CLA.

@ofw
Copy link
Contributor Author

ofw commented Jun 15, 2021

@ldez thank you, done!

ldez
ldez approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez removed the feedback required Requires additional feedback label Jun 15, 2021
@ldez ldez merged commit eed344f into golangci:master Jun 15, 2021
@golangci-automator
Copy link

Hey, @ofw — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ofw @SeigeC
revive: allow to disable rule (golangci#2055)
1fd2209
@ldez ldez added this to the v1.41 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
enhancement New feature or improvement
Projects
None yet
Milestone
v1.41
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ofw @CLAassistant @ldez