Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nolintlint: fix false positive. #2013

Merged
merged 2 commits into from May 31, 2021
Merged

nolintlint: fix false positive. #2013

merged 2 commits into from May 31, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented May 24, 2021 •
edited

the comments:

// nolintlint generates potential issues for every nolint directive and they are filtered out here

// nolintlint provides a linter to ensure that all //nolint directives are followed by explanations

produce false positives: nolintlint is seen as nolint directive.

@ldez ldez added the bug Something isn't working label May 24, 2021
@ldez ldez mentioned this pull request May 24, 2021
Closed
@ldez ldez force-pushed the fix/nolint-false-positive branch 2 times, most recently from 0695884 to 58c6e3d Compare May 24, 2021 20:24
@ldez ldez force-pushed the fix/nolint-false-positive branch from 58c6e3d to dcaf632 Compare May 29, 2021 18:45
bombsimon
bombsimon approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ldez ldez merged commit 6172338 into golangci:master May 31, 2021
@ldez ldez deleted the fix/nolint-false-positive branch May 31, 2021 07:04
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez @SeigeC
nolintlint: fix false positive. (golangci#2013)
bb672a4
@ldez ldez added this to the v1.41 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.41
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ldez @bombsimon