revive: fix excludes #2005
Merged
revive: fix excludes #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
feat/revive-excludes
branch
from
c6fb0f2
to
79efe3c
Compare
3 tasks
ldez
force-pushed
the
feat/revive-excludes
branch
from
79efe3c
to
5a7bec4
Compare
ernado
approved these changes
May 23, 2021
skaji
reviewed
Jun 18, 2021
| @@ -79,13 +79,25 @@ var DefaultExcludePatterns = []ExcludePattern{ | |||
| }, | |||
| { | |||
| ID: "EXC0012", | |||
| Pattern: "exported (method|function|type|const) (.+) should have comment or be unexported", | |||
| Pattern: `exported (.+) should have comment or be unexported`, | |||
There was a problem hiding this comment.
Unfortunately, this pattern does not match the actual message from revive.
❯ golangci-lint --version
golangci-lint has version 1.41.0 built from eed344f6 on 2021-06-16T19:58:50Z
❯ golangci-lint run
main.go:16:2: exported: exported const XXX should have comment (or a comment on this block) or be unexported (revive)
XXX = 0.1
@ldez Could you check that again?
There was a problem hiding this comment.
It's a specific case for const in a group, I will fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2004