importas: allow repeated aliases

[cbandy]

As described in #1959, the standalone importas tool does not restrict an alias to a single package. This aligns our configuration with the standalone tool.

It is a breaking change, but another breaking change to this linter's configuration is waiting to be released in ffe8061.

[ldez]

Could you explain why do you want to use several times the same alias for different imports?

[cbandy]

The way the file works now, I cannot configure these aliases with regex because both are $1$2:

k8s.io/api/apps/v1       -> appsv1
k8s.io/api/batch/v1      -> batchv1
k8s.io/api/batch/v1beta1 -> batchv1beta1
k8s.io/api/core/v1       -> corev1
k8s.io/api/events/v1     -> eventsv1
…

knative.dev/serving/pkg/apis/autoscaling/v1 -> autoscalingv1
knative.dev/serving/pkg/apis/serving/v1     -> servingv1

  importas:
    alias:
      "$1$2": 'k8s.io/api/(\w+)/(v[\w\d]+)'
      "$1$2": 'knative.dev/serving/pkg/apis/(\w+)/(v[\w\d]+)'

[ldez]

Ok now I understand 👍

I would suggest something like that:

  importas:
    # if set to `true`, force to use alias.
    no-unaliased: true
    # List of aliases
    alias:
      # using `servingv1` alias for `knative.dev/serving/pkg/apis/serving/v1` package
      - pkg: knative.dev/serving/pkg/apis/serving/v1
        alias: servingv1
      # using `autoscalingv1alpha1` alias for `knative.dev/serving/pkg/apis/autoscaling/v1alpha1` package
      - pkg: knative.dev/serving/pkg/apis/autoscaling/v1alpha1
        alias: autoscalingv1alpha1
      # You can specify the package path by regular expression,
      # and alias by regular expression expansion syntax like below.
      # see https://github.com/julz/importas#use-regular-expression for details
      - pkg: knative.dev/serving/pkg/apis/(\w+)/(v[\w\d]+)
        alias: $1$2

type ImportAsSettings struct {
	Alias       []ImportAsEntry
	NoUnaliased bool `mapstructure:"no-unaliased"`
}

type ImportAsEntry struct {
	Pkg   string
	Alias string
}

[cbandy]

Done.

[ldez]

LGTM

[golangci-automator]

Hey, @cbandy — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!