importas: add message if settings contain no aliases #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for opening your first Pull Request ! |
|
|
ldez
changed the title
|
Hey, @StephenBrown2 — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use the strict feature of importas, but forgot to also move my aliases under the
alias:key, and couldn't figure out why they weren't being applied. This message would have saved me a couple hours debugging the code to find out I should have just read the docs more closely.Initially I had it as a warning so it would show when running normally, but the tests (with --no-config) still created a default config for ImportAs, and so the output was flagged. An info message will be shown with --verbose, and should be sufficient, as that was the first thing I did to try to figure out if importas was getting filtered out for some reason.