Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wrapcheck to v2, add configuration #1947

Merged
merged 7 commits into from Apr 30, 2021
Merged

Update Wrapcheck to v2, add configuration #1947

merged 7 commits into from Apr 30, 2021

Conversation

tomarrell
Copy link
Member

Another wrapcheck update, this time with some configuration.

Recently added support to specify custom signatures to ignore when checking for wrapped errors making it more useful to people who want to use non-stdlib error wrapping.

Have given it a whirl, all looks good.

@tomarrell tomarrell requested a review from ldez April 30, 2021 16:27
@ldez ldez added the linter: update version Update version of linter label Apr 30, 2021
.golangci.example.yml Show resolved Hide resolved
pkg/golinters/wrapcheck.go Outdated Show resolved Hide resolved
tomarrell and others added 3 commits April 30, 2021 22:48
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 92fda26 into master Apr 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the wrapcheck-v2 branch April 30, 2021 22:13
@ldez ldez added this to the v1.40 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants