Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wsl to 3.3.0, sort config in example config #1922

Merged
merged 2 commits into from Apr 21, 2021

Conversation

bombsimon
Copy link
Member

  • Allow forcing short declarations to cuddle only with themselves
  • Allow a blank line after each comment group at the start of a block (not just between groups)

@bombsimon
Copy link
Member Author

CI seems really flaky, have to restart unit tests several times, mainly macOS failing. Also not sure why Nancy is blocking on jwt-go in this PR. Tried to look at the latest PRs but the jwt dependency hasn't been changed for a long time.

@ldez ldez added the linter: update version Update version of linter label Apr 21, 2021
@ldez
Copy link
Member

ldez commented Apr 21, 2021

The problem with jwt-go is not related to a change inside your PR but to the declaration of a CVE on this dependency.

We can skip because it's an indirect and unused dependency.

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ldez ldez merged commit d6bcf9f into golangci:master Apr 21, 2021
@ldez ldez added this to the v1.40 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants