Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version command output to Stdout #1869

Merged
merged 3 commits into from Mar 24, 2021
Merged

Conversation

clebs
Copy link
Contributor

@clebs clebs commented Mar 24, 2021

Default command output was set to Stderr, now set to Stdout.

Fixes #1868

Default command output was set to Stderr, now set to Stdout.

Signed-off-by: Borja Clemente <borja.clemente@gmail.com>
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 24, 2021

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Mar 24, 2021

CLA assistant check
All committers have signed the CLA.

pkg/commands/version.go Outdated Show resolved Hide resolved
@ldez ldez added the bug Something isn't working label Mar 24, 2021
Signed-off-by: Borja Clemente <borja.clemente@gmail.com>
Signed-off-by: Borja Clemente <borja.clemente@gmail.com>
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 814bf0e into golangci:master Mar 24, 2021
@golangci-automator
Copy link

Hey, @clebs — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@clebs clebs deleted the version-output-fix branch March 24, 2021 16:44
@clebs
Copy link
Contributor Author

clebs commented Mar 24, 2021

Thanks for the quick review!

@ldez ldez added this to the v1.39 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version: prints to Stderr instead of StdOut
3 participants