Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump wrapcheck to v1.0.0 #1863

Merged
merged 1 commit into from Mar 21, 2021
Merged

Bump wrapcheck to v1.0.0 #1863

merged 1 commit into from Mar 21, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 21, 2021

@ldez ldez added the linter: update version Update version of linter label Mar 21, 2021
sayboras
sayboras approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Just curious why you did this manually, will dependabot upgrade it or dependabot only works with vX.Y.Z version ?

@ldez
Copy link
Member Author

ldez commented Mar 21, 2021 •
edited

Yes dependabot only handle semver version, after this PR the dependency will be managed by the dependabot.

@ldez ldez merged commit 03992d0 into golangci:master Mar 21, 2021
@ldez ldez deleted the feat/bump-wrapcheck branch March 21, 2021 23:38
@ldez ldez added this to the v1.39 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
linter: update version Update version of linter
Projects
None yet
Milestone
v1.39
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ldez @sayboras