Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versions, improve deprecation system, improve linters page #1854

Merged
merged 4 commits into from Mar 17, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 16, 2021

Related to #1686

Render

Linters golangci-lint

since deprecated
asciicheck v1.26.0
bodyclose v1.18.0
cyclop v1.37.0
deadcode v1.0.0
depguard v1.4.0
dogsled v1.19.0
dupl v1.0.0
durationcheck v1.37.0
errcheck v1.0.0
errorlint v1.32.0
exhaustive v1.28.0
exhaustivestruct v1.32.0
exportloopref v1.28.0
forbidigo v1.34.0
forcetypeassert v1.38.0
funlen v1.18.0
gci v1.30.0
gochecknoglobals v1.12.0
gochecknoinits v1.12.0
gocognit v1.20.0
goconst v1.0.0
gocritic v1.12
gocyclo v1.0.0
godot v1.25.0
godox v1.19.0
goerr113 v1.26.0
gofmt v1.0.0
gofumpt v1.28.0
goheader v1.28.0
goimports v1.20.0
golint v1.0.0
gomnd v1.22.0
gomoddirectives v1.39.0
gomodguard v1.25.0
goprintffuncname v1.23.0
gosec v1.0.0
gosimple v1.20.0
govet v1.0.0
ifshort v1.36.0
importas v1.38.0
ineffassign v1.0.0
interfacer v1.0.0 v1.38.0
lll v1.8.0
makezero v1.34.0
maligned v1.0.0 v1.38.0
misspell v1.8.0
nakedret v1.9.0
nestif v1.25.0
nilerr v1.38.0
nlreturn v1.30.0
noctx v1.28.0
nolintlint v1.26.0
paralleltest v1.33.0
prealloc v1.9.0
predeclared v1.35.0
revive v1.37.0
rowserrcheck v1.23.0
scopelint v1.12 v1.39.0
sqlclosecheck v1.28.0
staticcheck v1.0.0
structcheck v1.0.0
stylecheck v1.20.0
testpackage v1.25.0
thelper v1.34.0
tparallel v1.32.0
typecheck v1.3.0
unconvert v1.0.0
unparam v1.9.0
unused v1.20.0
varcheck v1.0.0
wastedassign v1.38.0
whitespace v1.19.0
wrapcheck v1.32.0
wsl v1.20.0

@ldez ldez changed the title Add version, improve deprecation system, improve linter page Add versions, improve deprecation system, improve linter page Mar 16, 2021
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Is WithSince clear enough that you should add what you believe to be the next version or should we add some information to the docs? I see you only added minor versions, have new linters never been added in a patch? (If not that's good because we probably shouldn't).

@ldez
Copy link
Member Author

ldez commented Mar 17, 2021

I see you only added minor versions, have new linters never been added in a patch? (If not that's good because we probably shouldn't).

I checked all the versions even the patch versions and everything is good except for v1.35.1 but we retracted/canceled by creating the v3.5.2.

v1: deadcode, dupl, errcheck, gas, goconst, gocyclo, gofmt, golint, govet, ineffassign, interfacer, maligned, megacheck, structcheck, unconvert, varcheck
v1.1: -
v1.2: -
v1.2.1: -
v1.3: + typecheck
v1.3.1: -
v1.3.2: -
v1.3.3: -
v1.3.4: -
v1.3.5: -
v1.3.6: -
v1.3.7: -
v1.4: + depguard
v1.4.1: -
v1.5: -
v1.6: -
v1.6.1: -
v1.7: -
v1.7.1: -
v1.7.2: -
v1.7.3: -
v1.8: + lll, misspell
v1.8.1: -
v1.9: + nakedret, prealloc, unparam
v1.9.1: -
v1.9.2: -
v1.9.3: -
v1.10: -
v1.10.1: -
v1.10.2: -
v1.11: -
v1.11.1: -
v1.11.2: -
v1.11.3: -
v1.12: + gochecknoglobals, gochecknoinits, gocritic, scopelint
v1.12.1: -
v1.12.2: -
v1.12.3: -
v1.12.4: -
v1.12.5: -
v1.13: gas -> gosec
v1.13.1: -
v1.13.2: -
v1.14.0: -
v1.15.0: -
v1.16.0: -
v1.17.0: -
v1.17.1: -
v1.18.0: + bodyclose, funlen
v1.19.0: + dogsled, godox, whitespace
v1.19.1: -
v1.20.0: + gocognit, goimports, gosimple, staticcheck, stylecheck, unused, wsl
v1.20.1: -
v1.21.0: -
v1.22.0: + gomnd
v1.22.1: -
v1.22.2: -
v1.23.0: + goprintffuncname, rowerrcheck
v1.23.1: -
v1.23.2: -
v1.23.3: -
v1.23.4: -
v1.23.5: -
v1.23.6: -
v1.23.7: -
v1.23.8: -
v1.24.0: -
v1.25.0: + godot, gomodguard, nestif, testpackage
v1.25.1: -
v1.26.0: + asciicheck, goerr113, nolintlint
v1.27.0: -
v1.28.0: + exhaustive, gofumpt, goheader, noctx, sqlclosecheck, exportloopref
v1.28.1: -
v1.28.2: -
v1.28.3: -
v1.29.0: -
v1.30.0: + gci, nlreturn
v1.31.0: -
v1.32.0: + errorlint, exhaustivestruct, tparallel, wrapcheck
v1.32.1: -
v1.32.2: -
v1.33.0: + paralleltest
v1.33.1: -
v1.33.2: -
v1.34.0: + forbidigo, makezero, thelper
v1.34.1: -
v1.35.0: + predeclared
v1.35.1: (cancelled)
v1.35.2: -
v1.36.0: + ifshort
v1.37.0: + cyclop, durationcheck, revive
v1.37.1: -
v1.38.0: + forcetypeassert, importas, nilerr, wastedassign

@ldez ldez changed the title Add versions, improve deprecation system, improve linter page Add versions, improve deprecation system, improve linters page Mar 17, 2021
@ldez ldez merged commit 8db518c into golangci:master Mar 17, 2021
@ldez ldez deleted the feat/since branch March 17, 2021 15:17
@ldez ldez mentioned this pull request Jun 5, 2023
@ldez ldez added this to the v1.39 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants