Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new presets #1847

Merged
merged 2 commits into from Mar 16, 2021
Merged

Add new presets #1847

merged 2 commits into from Mar 16, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 15, 2021

I would like to add new presets:

  • import
  • module
  • comment
  • metalinter
  • test
  • error
  • sql
format complexity style bugs unused performance PROPOSAL
deadcode
errcheck error
gosimple
govet metalinter
ineffassign
staticcheck metalinter
structcheck
typecheck
unused
varcheck
asciicheck
bodyclose http?
cyclop
depguard import, module
dogsled
dupl
durationcheck
errorlint error
exhaustive
exhaustivestruct
exportloopref
forbidigo
forcetypeassert
funlen move to complexity
gci import
gochecknoglobals
gochecknoinits
gocognit
goconst
gocritic metalinter
gocyclo
godot comment
godox comment
goerr113 error
gofmt
gofumpt
goheader
goimports import
golint
gomnd
gomoddirectives module
gomodguard import, module
goprintffuncname
gosec metalinter?
ifshort
importas
interfacer
lll
makezero
maligned
misspell comment
nakedret move to style
nestif
nilerr
nlreturn
noctx http?
nolintlint
paralleltest test
prealloc
predeclared
revive metalinter
rowserrcheck sql
scopelint
sqlclosecheck sql
stylecheck
testpackage test
thelper test
tparallel test
unconvert
unparam
wastedassign
whitespace
wrapcheck error
wsl

@ldez ldez added the enhancement New feature or improvement label Mar 15, 2021
@ldez ldez changed the title Add new presets. Add new presets Mar 15, 2021
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider adding comments for each preset to clarify for new contributors how to select presets for their linters.

In general, LGTM

@ldez ldez merged commit b6a6faa into golangci:master Mar 16, 2021
@ldez ldez deleted the feat/new-presets branch March 16, 2021 12:33
@ldez ldez added this to the v1.39 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants