Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate ImportAs linter #1783

Merged
merged 2 commits into from Feb 26, 2021
Merged

Integrate ImportAs linter #1783

merged 2 commits into from Feb 26, 2021

Conversation

SVilgelm
Copy link
Member

@SVilgelm SVilgelm commented Feb 26, 2021 •
edited by ldez

@SVilgelm SVilgelm added linter: new Support new linter blocked Need's direct action from maintainer labels Feb 26, 2021
@SVilgelm
Copy link
Member Author

Blocked until julz/importas#1

@ldez ldez marked this pull request as draft February 26, 2021 08:03
@ldez ldez changed the title WIP: Integrate ImportAs linter Integrate ImportAs linter Feb 26, 2021
@SVilgelm SVilgelm removed the blocked Need's direct action from maintainer label Feb 26, 2021
@SVilgelm SVilgelm marked this pull request as ready for review February 26, 2021 15:36
@SVilgelm SVilgelm requested a review from a team February 26, 2021 15:37
@ldez ldez self-requested a review February 26, 2021 15:52
@SVilgelm
Copy link
Member Author

👍

ldez
ldez approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SVilgelm SVilgelm merged commit 05836e4 into master Feb 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the importas branch February 26, 2021 19:08
@ldez ldez mentioned this pull request Feb 26, 2021
Closed
@julz julz mentioned this pull request Mar 4, 2021
Merged
This was referenced Mar 7, 2021
Closed
Open
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
This was referenced Mar 12, 2021
Closed
Closed
Merged
Closed
@ldez ldez added this to the v1.38 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
linter: new Support new linter
Projects
None yet
Milestone
v1.38
Development

Successfully merging this pull request may close these issues.

Add julz/importas linter
2 participants
@SVilgelm @ldez