durationcheck: False positive when multiplying with int type struct field #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
bug
ldez
force-pushed
the
fix/durationcheck
branch
3 times, most recently
from
8d32966
to
5645d4c
Compare
ldez
changed the title
ldez
force-pushed
the
fix/durationcheck
branch
from
5645d4c
to
d2157b8
Compare
ldez
force-pushed
the
fix/durationcheck
branch
from
d2157b8
to
0547fae
Compare
|
@bombsimon could you take a look at this PR like that I will be able to create a bug fix version (v1.37.1) |
bombsimon
approved these changes
Feb 20, 2021
|
|
||
| func durationcheckCase03() { | ||
| seconds := 10 | ||
| fmt.Print(time.Duration(seconds) * time.Second) |
There was a problem hiding this comment.
Why doesn't this yield an error? 🤔
There was a problem hiding this comment.
because time.Duration is a int64 (type Duration int64) so in this case: seconds (int) is just converted to int64 (Duration).
time.Duration(10) means 10 nanoseconds.
time.Duration(seconds) * time.Second
=> int64(seconds) * time.Second
=> 10 * time.Second
ashanbrown
pushed a commit
to ashanbrown/golangci-lint
that referenced
this pull request
Feb 20, 2021
This was referenced Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to charithe/durationcheck#7