Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression: update thelper to v0.2.1 #1639

Merged
merged 4 commits into from
Jan 9, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented Jan 9, 2021

diff: kulti/thelper@v0.2.0...v0.2.1

With v0.2.0, all the sub-test functions are detected as a problem.

@ldez ldez added the bug Something isn't working label Jan 9, 2021
@ldez ldez requested a review from kulti January 9, 2021 02:16
go.sum Show resolved Hide resolved
Copy link
Contributor

@kulti kulti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/testdata/thelper.go Outdated Show resolved Hide resolved
@ldez ldez dismissed SVilgelm’s stale review January 9, 2021 19:21

everything is fixed

@ldez ldez merged commit 44bf197 into golangci:master Jan 9, 2021
@ldez ldez deleted the feat/update-thelper branch January 9, 2021 19:21
ashanbrown pushed a commit to ashanbrown/golangci-lint that referenced this pull request Feb 20, 2021
@ldez ldez added this to the v1.35 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants