Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: rename internal nolintlint linter to nolint #1600

Open
ashanbrown opened this issue Dec 31, 2020 · 1 comment
Open

Proposal: rename internal nolintlint linter to nolint #1600

ashanbrown opened this issue Dec 31, 2020 · 1 comment
Labels
area: nolint Related to nolint directive and nolintlint enhancement New feature or improvement
Milestone

Comments

@ashanbrown
Copy link
Contributor

ashanbrown commented Dec 31, 2020

Is your feature request related to a problem? Please describe.
I'm concerned that the nolintlint name is a bit confusing and that that nolint might be a more obvious name for nolintlint.

Describe the solution you'd like
Rename nolintlint in configs and internal objects to nolint. Continue to support nolintlint as a deprecated config option.

Describe alternatives you've considered
Leave it alone or call the linter itself nolinter while possibly still allowing the config options to be set under the keynolint.

Additional context
Once we merge #1583 , we start allowing //nolint:nolintlint to disable nolintlint checks but I think these might look bitter as //nolint:nolint. If we make this change, it would be nice to do so before people start adding //nolint:nolintlint to their code. I don't believe //nolint:nolintlint works right now.

@ashanbrown ashanbrown added the enhancement New feature or improvement label Dec 31, 2020
@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No recent correspondence or work activity label Jan 8, 2022
@ldez ldez removed the stale No recent correspondence or work activity label Jan 9, 2022
@ldez ldez added this to the v2.0.0 milestone Jan 9, 2022
@ldez ldez added the area: nolint Related to nolint directive and nolintlint label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: nolint Related to nolint directive and nolintlint enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants