Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modules-download-mode support #1593

Merged
merged 2 commits into from Jan 7, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented Dec 29, 2020

related to golang/go#43418

Fixes #1502
Fixes #1633
Closes #1635

related to #1592

@ldez
Copy link
Member Author

ldez commented Dec 30, 2020

The problem will be fixed by the Go Team https://go-review.googlesource.com/c/tools/+/280694

Wait and see 😉

@ldez
Copy link
Member Author

ldez commented Jan 6, 2021

the issue has been fixed golang/go#43418 , so now we have to merge this PR. @golangci/team @sayboras

@ldez ldez added the bug Something isn't working label Jan 6, 2021
@ldez
Copy link
Member Author

ldez commented Jan 7, 2021

ping @golangci/team

@ldez ldez force-pushed the fix/module-download-mode branch 2 times, most recently from 4e4d8ff to aa15784 Compare January 7, 2021 17:43
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 1e5ba1e into golangci:master Jan 7, 2021
@ldez ldez deleted the fix/module-download-mode branch January 7, 2021 22:37
ashanbrown pushed a commit to ashanbrown/golangci-lint that referenced this pull request Feb 20, 2021
@ldez ldez added this to the v1.35 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants