Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve custom linters' path relative to config file directory #1572

Merged
merged 1 commit into from
Dec 26, 2020

Conversation

siliconbrain
Copy link
Contributor

Resolves #1085 by interpreting non-absolute plugin paths relative to the config file's directory (or the current working directory if no config file is used).

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 22, 2020

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ernado ernado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added the enhancement New feature or improvement label Dec 26, 2020
@ernado ernado merged commit df9278e into golangci:master Dec 26, 2020
@golangci-automator
Copy link

Hey, @siliconbrain — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom plugins path should be relative to the configuration file
4 participants