Add forbidigo linter #1569
Merged
Add forbidigo linter #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashanbrown
force-pushed
the
asb/forbidigo
branch
3 times, most recently
from
7293bd5
to
110a30c
Compare
ldez
requested changes
Dec 24, 2020
ashanbrown
force-pushed
the
asb/forbidigo
branch
from
611242b
to
027dc68
Compare
|
Should we be verifying that |
Forbidigo forbids identifiers. It can be used to forbid code that is useful for debugging but should not be merged to the master branch.
ashanbrown
force-pushed
the
asb/forbidigo
branch
from
027dc68
to
a6043b4
Compare
|
@ashanbrown there was an RP to change this behavior #1397. I think that this PR can be reverted since dependabot is now able to manage |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forbidigo forbids identifiers. It can be used to forbid code that is useful for debugging but should not be merged to the master branch. I've found it particularly useful to make sure I don't commit
fmt.Print.*statements orginkgo.F.*commands that I've introduced during local debugging.Not sure if there is another linter that already does this. Please let me know if there is.
Base linter is at https://github.com/ashanbrown/forbidigo