Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings examples for gocritic #1562

Merged
merged 5 commits into from
Dec 18, 2020
Merged

Conversation

sebastien-rosset
Copy link
Contributor

Add gocritic settings in the example file.

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 17, 2020

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2020

CLA assistant check
All committers have signed the CLA.

@ldez ldez changed the title Add setttings examples for gocritic Add settings examples for gocritic Dec 17, 2020
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to reference the documentation instead of the gocritic command line.

.golangci.example.yml Outdated Show resolved Hide resolved
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ldez ldez merged commit 87cdb2d into golangci:master Dec 18, 2020
@golangci-automator
Copy link

Hey, @sebastien-rosset — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@ldez ldez added this to the v1.34 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants