Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump github.com/tommy-muehle/go-mnd@v2.2.0 #1558

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 14, 2020

Closes #1557

Upstream project does not support Go Modules to reference @v2.2.0 directly, so used commit at that tag.

Updated via:

$ go get github.com/tommy-muehle/go-mnd@16041ac3fe65b98fbbf4c3c9b88c346196211614
$ go mod tidy

Reference: golangci#1557

Upstream project does not support Go Modules to reference @v2.2.0 directly, so used commit at that tag.

Updated via:

```console
$ go get github.com/tommy-muehle/go-mnd@16041ac3fe65b98fbbf4c3c9b88c346196211614
$ go mod tidy
```
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 14, 2020

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2020

CLA assistant check
All committers have signed the CLA.

@ldez ldez added the linter: update version Update version of linter label Dec 14, 2020
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tommy-muehle Is it possible to support proper versioning and update your go.mod with a /v2 to enable us to pin releases instead of commits?

@bombsimon bombsimon merged commit e26630a into golangci:master Dec 14, 2020
@golangci-automator
Copy link

Hey, @bflad — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@bflad bflad deleted the deps-go-mnd-v2.2.0 branch December 15, 2020 00:46
@ldez ldez mentioned this pull request Jan 20, 2021
3 tasks
@ldez ldez added this to the v1.34 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update go-mnd for -ignore-functions Support
4 participants