Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): Fix docker tag for alpine build #1487

Merged
merged 1 commit into from Nov 3, 2020
Merged

fix(docker): Fix docker tag for alpine build #1487

merged 1 commit into from Nov 3, 2020

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Nov 2, 2020 •
edited

Description

This commit is to avoid tag overriding due to parallel build for
multiple base images (e.g. debian and alpine).

Closes #1483
Closes #1486

Signed-off-by: Tam Mach sayboras@yahoo.com

Testing

Testing was done for forked docker hub (e.g. sayboras/golangci-lint).

$ docker run -it --entrypoint /bin/sh sayboras/golangci-lint:v1.32.2 -c 'cat /etc/os-release'
PRETTY_NAME="Debian GNU/Linux 10 (buster)"
NAME="Debian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
$ docker run -it --entrypoint /bin/sh sayboras/golangci-lint:latest -c 'cat /etc/os-release'
PRETTY_NAME="Debian GNU/Linux 10 (buster)"
NAME="Debian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

$ docker run -it --entrypoint /bin/sh sayboras/golangci-lint:v1.32.2-alpine -c 'cat /etc/os-release'
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.12.1
PRETTY_NAME="Alpine Linux v3.12"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://bugs.alpinelinux.org/"
$ docker run -it --entrypoint /bin/sh sayboras/golangci-lint:latest-alpine -c 'cat /etc/os-release'
Unable to find image 'sayboras/golangci-lint:latest-alpine' locally
latest-alpine: Pulling from sayboras/golangci-lint
Digest: sha256:677a3a1a3a4b5f0fc0bc3af0b5c08253e2f6ed02b0bf4ffe614b1b7cfaefc320
Status: Downloaded newer image for sayboras/golangci-lint:latest-alpine
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.12.1
PRETTY_NAME="Alpine Linux v3.12"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://bugs.alpinelinux.org/"

@sayboras
fix(docker): Fix docker tag for alpine build
9250f4c 
This commit is to avoid tag overriding due to parallel build for
multiple base images (e.g. debian and alpine).

Closes golangci#1483 golangci#1486

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@sayboras sayboras requested review from a team November 2, 2020 09:31
@sayboras sayboras mentioned this pull request Nov 2, 2020
Closed
3 tasks
invidian
invidian approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sayboras
Copy link
Member Author

sayboras commented Nov 2, 2020

Thanks guys for reviewing, maybe I will merge tmr if there is no more comment, and release v1.32.2 as well.

@sayboras sayboras merged commit 52d26a3 into golangci:master Nov 3, 2020
@ldez ldez added this to the v1.32 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernado ernado ernado approved these changes

@invidian invidian invidian approved these changes

Assignees
No one assigned
Labels
area: docker
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.

latest docker image switched from Debian to Alpine Make missing in v1.32.1 Docker image
4 participants
@sayboras @ernado @invidian @ldez