Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exhaustivestruct linter #1411

Merged
merged 6 commits into from Oct 12, 2020
Merged

Add exhaustivestruct linter #1411

merged 6 commits into from Oct 12, 2020

Conversation

mbilski
Copy link
Contributor

@mbilski mbilski commented Oct 4, 2020

Add exhaustivestruct linter.

In my case, I use it to make sure that my SQL <-> Domain mappings always have all the fields initialized.

Definitely, it is a linter that you might want to use only for specific files where you want to make sure that you did not forget to add a field.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 4, 2020

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please rebase on master and fix the conflicts?

@bombsimon bombsimon merged commit c57627b into golangci:master Oct 12, 2020
@golangci-automator
Copy link

Hey, @mbilski — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@ldez ldez added the linter: new Support new linter label Dec 7, 2020
@sudo-suhas
Copy link

@mbilski sorry to bring this up on a old thread but is there any way to specify the struct_patterns while running this through golangci-lint?

@ldez
Copy link
Member

ldez commented Feb 18, 2021

@sudo-suhas currently it's not possible.

@ldez ldez added this to the v1.32 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: new Support new linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants