Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapcheck linter #1407

Merged
merged 3 commits into from Oct 6, 2020
Merged

Add wrapcheck linter #1407

merged 3 commits into from Oct 6, 2020

Conversation

tomarrell
Copy link
Member

This PR introduces the wrapcheck linter.

There is a more extensive write-up about the functionality and justification for this linter here: https://blog.tomarrell.com/post/introducing_wrapcheck_linter_for_go

The test added here is just a minimal example, there is a more extensive suite included in the repository.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 2, 2020

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2020

CLA assistant check
All committers have signed the CLA.

@Nivl
Copy link
Member

Nivl commented Oct 3, 2020

Looks good to me, I'll approve once you fixed the conflicts.

@tomarrell
Copy link
Member Author

Cheers for that @Nivl, have resolved the conflict. Should be good to go.

Copy link
Member

@Nivl Nivl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tomarrell
Copy link
Member Author

@Nivl, just wondering if there is anything else that needs to be done before this can be merged? I don't have write access.

Thanks! 🙂

@bombsimon
Copy link
Member

bombsimon commented Oct 6, 2020

Nope, let's merge this! Thanks for the PR!

@bombsimon bombsimon merged commit 247b6c2 into golangci:master Oct 6, 2020
@golangci-automator
Copy link

Hey, @tomarrell — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@ldez ldez added the linter: new Support new linter label Dec 7, 2020
@ldez ldez added this to the v1.32 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: new Support new linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants