Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for only specifying default severity #1396

Merged
merged 2 commits into from Oct 19, 2020
Merged

Added support for only specifying default severity #1396

merged 2 commits into from Oct 19, 2020

Conversation

ac-rappi
Copy link
Contributor

Default severity is only used when rules are not empty

Make sure the rules transformations for modifying severity are skipped if there are not rules AND no default severity specified

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 25, 2020

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@ac-rappi ac-rappi closed this Sep 25, 2020
@ac-rappi ac-rappi reopened this Sep 25, 2020
@ac-rappi ac-rappi closed this Sep 25, 2020
@ac-rappi ac-rappi reopened this Oct 13, 2020
alejandrocragnolini
alejandrocragnolini approved these changes Oct 13, 2020
View reviewed changes
Copy link

@alejandrocragnolini alejandrocragnolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1!

@andres-loyola
Copy link

+1

@sayboras sayboras requested a review from a team October 18, 2020 06:05
daixiang0
daixiang0 approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sayboras sayboras merged commit 9b3ba43 into golangci:master Oct 19, 2020
@golangci-automator
Copy link

Hey, @ac-rappi — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@ldez ldez added this to the v1.32 milestone Mar 6, 2024
@ldez ldez added area: severity enhancement New feature or improvement labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrocragnolini alejandrocragnolini alejandrocragnolini approved these changes

@daixiang0 daixiang0 daixiang0 approved these changes

Assignees
No one assigned
Labels
area: severity enhancement New feature or improvement
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ac-rappi @CLAassistant @andres-loyola @alejandrocragnolini @daixiang0 @ldez @sayboras