build(dep): Ignore known dependency failure in nancy #1378
Merged
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently nancy is always failed, and we seem to ignore it completely. This reduces the value of having security scanning significantly. Ideally, the underlying issue should be fixed, however it will require long time for external collaboration. This commit is to ignore two known dependency failures. Signed-off-by: Tam Mach <sayboras@yahoo.com>
sayboras
commented
Sep 20, 2020
| - name: Run go list | ||
| run: go list -json -m all > go.list | ||
| - name: Nancy | ||
| uses: sonatype-nexus-community/nancy-github-action@master |
There was a problem hiding this comment.
changed to github action as it's updated to the latest now, another benefit is that we don't need to mount volume for .nancy-ignore file.
sayboras
commented
Sep 20, 2020
| @@ -0,0 +1,11 @@ | |||
| # Skip for golang/golang.org/x/net@v0.0.0-20200904194848-62affa334b73 | |||
There was a problem hiding this comment.
latest x/net package is still having some vulnerbilities
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently nancy is always failed, and we seem to ignore it completely.
This reduces the value of having security scanning significantly.
Ideally, the underlying issue should be fixed, however it will require
long time for external collaboration.
This commit is to ignore two known dependency failures.
Signed-off-by: Tam Mach sayboras@yahoo.com
Note: ignoring any dependency must be consious choice.