Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To enable v1.28 in github action #1207

Merged
merged 2 commits into from Jul 5, 2020

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Jul 5, 2020

Update github-action.json and README.md by running below make target.

make assets/github-action-config.json
make update_contributors_list

@sayboras sayboras force-pushed the feature/enable-1-28-gh-action branch from 364df05 to aa7b478 Compare July 5, 2020 01:17
@sayboras
Copy link
Member Author

sayboras commented Jul 5, 2020

Need to investigate on how to automate this

Update REAME.md

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@sayboras sayboras force-pushed the feature/enable-1-28-gh-action branch from aa7b478 to 9e779cc Compare July 5, 2020 01:41
@sayboras
Copy link
Member Author

sayboras commented Jul 5, 2020

@jirfag @ernado I ran make expand_website_templates to update the website as well, but then it will replace template, which make it hard to update again in next release. Need your input on this.

Updated: I only checked in template_data.state

Signed-off-by: Tam Mach <sayboras@yahoo.com>
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@sayboras sayboras merged commit fbce520 into golangci:master Jul 5, 2020
@sayboras sayboras deleted the feature/enable-1-28-gh-action branch July 5, 2020 08:07
@ldez ldez added this to the v1.28 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants