Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use golangci-lint 1.28 to lint golangci-lint codebase #1206

Merged
merged 1 commit into from Jul 5, 2020

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Jul 5, 2020

Signed-off-by: Tam Mach sayboras@yahoo.com

@sayboras sayboras marked this pull request as draft July 5, 2020 00:58
@sayboras sayboras force-pushed the feature/action-1-28 branch 5 times, most recently from d9ff98b to 88bee2d Compare July 5, 2020 01:09
@sayboras
Copy link
Member Author

sayboras commented Jul 5, 2020

Build failed, waiting for PR #1207

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@sayboras sayboras marked this pull request as ready for review July 5, 2020 08:12
@sayboras sayboras requested a review from a team July 5, 2020 08:12
@sayboras sayboras changed the title Use latest golangci-lint to lint golangci-lint Use golangci-lint 1.28 to lint golangci-lint codebase Jul 5, 2020
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sayboras sayboras merged commit afa9be6 into golangci:master Jul 5, 2020
@sayboras sayboras deleted the feature/action-1-28 branch July 5, 2020 08:21
@sayboras sayboras added the area: tests Continuous integration, tests and other checks label Jul 5, 2020
@ldez ldez added this to the v1.28 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests Continuous integration, tests and other checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants