New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fish completion #1201
Conversation
4d56cd3
to
ba05e4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention golangci/team
when your Cobra PR is merged.
ba05e4e
to
7779cae
Compare
7779cae
to
4f1ac04
Compare
5b27d33
to
59232e6
Compare
59232e6
to
63b6ab9
Compare
63b6ab9
to
2889c98
Compare
@golangci/team seems like cobra might take time to release tagged version, just wanna check if you guys are ok with git hash version from master. If yes, I can merge this in, otherwise, will mark this as draft. |
Co-authored-by: Sascha Grunert <sgrunert@suse.com>
This commit is to use tag version for cobra (e.g. 1.1.1). The main benefit is that this can be managed and upgraded by dependabot later. This is follow-up item from PR golangci#1201. Signed-off-by: Tam Mach <sayboras@yahoo.com>
This commit is to use tag version for cobra (e.g. 1.1.1). The main benefit is that this can be managed and upgraded by dependabot later. This is follow-up item from PR #1201. Signed-off-by: Tam Mach <sayboras@yahoo.com>
@sayboras hi, I generate completion script at this directory by but encouter issue when ➜ completions golangci-lint run math: Error: Unexpected token
'ompletion ended with directive: ShellCompDirectiveDefault / 1'
^
math: Error: Unexpected token
'% 2'
^
test: Missing argument at index 2
~/.config/fish/completions/golangci-lint.fish (line 99):
if test $compErr -eq 1
^
in function '__golangci_lint_prepare_completions'
in command substitution
(Type 'help test' for related documentation)
math: Error: Unexpected token
'ompletion ended with directive: ShellCompDirectiveDefault / 8'
^
math: Error: Unexpected token
'% 2'
^ golangci-lint has version 1.33.0 built from b90551c on 2020-11-23T06:54:06Z |
have you try with
|
Add completion support for fish shell