Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedded errcheck linter errors are not the same as with running standalone errcheck #1194

Closed
hellt opened this issue Jun 21, 2020 · 2 comments · Fixed by #1319
Closed

embedded errcheck linter errors are not the same as with running standalone errcheck #1194

hellt opened this issue Jun 21, 2020 · 2 comments · Fixed by #1319
Assignees
Labels
feedback required Requires additional feedback

Comments

@hellt
Copy link

hellt commented Jun 21, 2020

Hi, thanks for creating this gh action

I receive inconsistent results with this action considering the errcheck linter. If I run the latest errcheck downloaded with go get I receive an extensive report, whereas running golang-ci-lint action with default configuration I see just a fraction of errcheck linter errors.
What could be the potential reason? This is my test run log:

2020-06-21T07:53:29.1627489Z Running [/home/runner/golangci-lint-1.27.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
2020-06-21T07:53:30.6448589Z ##[error]Error return value of `reqCapability` is not checked (errcheck)
2020-06-21T07:53:30.6452862Z ##[error]Error return value of `viper.BindPFlag` is not checked (errcheck)
2020-06-21T07:53:30.6453512Z ##[error]Error return value of `getCmd.MarkFlagRequired` is not checked (errcheck)
2020-06-21T07:53:30.6454304Z ##[error]Error return value of `viper.BindPFlag` is not checked (errcheck)
2020-06-21T07:53:30.6454990Z ##[error]Error return value of `viper.BindPFlag` is not checked (errcheck)
2020-06-21T07:53:30.6455423Z ##[error]Error return value of `server.grpcServer.Serve` is not checked (errcheck)
2020-06-21T07:53:30.6455859Z ##[error]Error return value of `viper.ReadInConfig` is not checked (errcheck)
2020-06-21T07:53:30.6456332Z ##[error]Error return value of `subscribeCmd.MarkFlagRequired` is not checked (errcheck)

and the output of the errcheck is far more complete for the same commit https://gist.github.com/hellt/9f02f6c8a2e768fb3d9d25cbcb6f432b

@jirfag jirfag transferred this issue from golangci/golangci-lint-action Jun 21, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 21, 2020

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@iwankgb
Copy link
Contributor

iwankgb commented Jul 4, 2020

@hellt can you provide:

  • golangci-lint version.
  • content of .golangci-lint.yaml file
  • CLI arguments that you use for golangci-lint
  • snippet of code to replicate the issue.

From the top of my head: there as some settings that may affect output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback required Requires additional feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants