Protect NewFilenameUnadjuster from concurrent map writes #1192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As signalled in #612 there has been another occurrence of concurrent map writes.
This should address the issue by passing a mutex alongside the map and locking it when writing. Given that the concurrent writes are only occurring while the map is being filled we do not need to pass the mutex back as part of the
FilenameUnadjuster
struct. Consumers of this type should protect against concurrency issues themselves when operating on the enclosed map field.