Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update new-linters doc #1167

Merged
merged 1 commit into from May 25, 2020
Merged

update new-linters doc #1167

merged 1 commit into from May 25, 2020

Conversation

nishanths
Copy link
Contributor

This updates the new-linters doc. I've fixed a filename (lintersdb.go -> manager.go), and remove outdated line numbers from the links.

If preferred, I can add correct line numbers using a GitHub link at a fixed commit instead of master — to avoid the line numbers being outdated again.

Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jirfag jirfag merged commit 6684c8b into golangci:master May 25, 2020
@jirfag
Copy link
Member

jirfag commented May 25, 2020

thank you!

@golangci-automator
Copy link

Hey, @nishanths — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@nishanths nishanths deleted the new-linters-doc branch May 25, 2020 16:46
@ldez ldez added the area: docs label Dec 7, 2020
@ldez ldez added this to the v1.28 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants