Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax highlighting for bash scripts #1151

Merged
merged 1 commit into from May 18, 2020

Conversation

juliaogris
Copy link
Member

@juliaogris juliaogris commented May 18, 2020

Fix syntax highlighting for bash scripts by changing language from
bash to sh in triple-backtick blocks:

```bash -> ```sh

Some of these blocks had command output or prompt as part of the
listening which formatted in odd ways, e.g. colouring every occurrence
of the word "for" or "help" in purple.

With the sh language specification these wrong colours are gone, so
use it.

Preview: https://5ec28397326bcc000775cfe6--unruffled-torvalds-a209db.netlify.app/contributing/website/

Fix syntax highlighting for bash scripts by changing language from
bash to sh in triple-backtick blocks: ```bash -> ```sh.

Some of these blocks had command output or prompt as part of the
listening which formatted in odd ways, e.g. colouring every occurrence
of the word "for" or "help" in purple.

With the sh language specification these wrong colours are gone, so use
it.
@boring-cyborg
Copy link

boring-cyborg bot commented May 18, 2020

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented May 18, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@jirfag jirfag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!

@jirfag jirfag merged commit ba6476a into golangci:master May 18, 2020
@golangci-automator
Copy link

Hey, @juliaogris — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@ldez ldez added this to the v1.28 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants