Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-err113 #1093

Closed
jackwhelpton opened this issue May 15, 2020 · 3 comments
Closed

Update go-err113 #1093

jackwhelpton opened this issue May 15, 2020 · 3 comments
Labels
enhancement New feature or improvement good first issue Good for newcomers linter: update version Update version of linter

Comments

@jackwhelpton
Copy link

I recently resolved a bug in go-err113 that led to false positives for the "do not define dynamic errors" warning: this is in the commit 5174e21577d5ed9c53d9f62d2eecf64c16b86aa0, merged to master 4 days ago:

Djarvur/go-err113@5174e21

Unfortunately this doesn't seem to have been picked up in the latest golangci-lint release 2 days ago. I'm guessing it's as simple as a go.mod update: I can submit a PR if that's the recommended approach?

@bombsimon
Copy link
Member

That is correct, updating go.mod and vendoringin dependencies in a PR and it will be included in the next release!

@jirfag jirfag added linter: update version Update version of linter enhancement New feature or improvement good first issue Good for newcomers labels May 17, 2020
@jackwhelpton
Copy link
Author

Ah, it looks like something runs that raises these PRs automatically?

#1099

As that's merged, I'm guessing this issue can be closed?

@bombsimon
Copy link
Member

Yeah, sorry! I didn't know the auto update was running for packages not using semver but it seems like it's running for any dependency. So from now on, all that's needed is a successful build and an approval and then we can merge updates in dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement good first issue Good for newcomers linter: update version Update version of linter
Projects
None yet
Development

No branches or pull requests

3 participants